Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 )
Change subject: IMPALA-6719: Reset metadata database name case sensitivity ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9788/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java File fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java: http://gerrit.cloudera.org:8080/#/c/9788/1/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java@60 PS1, Line 60: > In general, toSql() represents SQL of an analyzed statement where all entit makes sense. for this case, I didn't see a reason why case should be handled differently from the way its done in TableName (keep user input, do toLowerCase where needed). -- To view, visit http://gerrit.cloudera.org:8080/9788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id880aa559cec0afe8fbb7d33ccce83f7b5e474cb Gerrit-Change-Number: 9788 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 16:53:14 +0000 Gerrit-HasComments: Yes
