Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9770
to look at the new patch set (#9).
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary
search
......................................................................
IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
IMPALA-5721:
- Save profiles of queries at the end of both the spilling and
non-spilling binary search. These were not being saved before. Note
these profiles won't have ExecSummary until IMPALA-6640 is addressed.
- Save the profile of any query that produces incorrect results during
binary search. These were not being saved before, either.
- Use descriptive names, like
tpch_100_parquet_q12_profile_without_spilling.txt, for profiles
mentioned above. We do this by introducing the concept of a
"logical_query_id" whose values look like "tpch_100_parquet_q12".
- Use the logical_query_id in critical error paths and include the
logical_query_id in result hash files.
IMPALA-6717:
- Plumb --common-query-options through to the binary search.
IMPALA-6738:
- Begin a refactoring to reduce the number of parameters used when doing
the binary search.
- Introduce a notion of "converted args" via class that does the
conversion (if needed) via property getters.
- Adjust populate_all_queries() to use converted_args
Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
---
M tests/stress/concurrent_select.py
1 file changed, 213 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/9770/9
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Nithya Janarthanan <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>