Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@141 PS7, Line 141: if hasattr(self, curate_method_name): > Yeah, __getattribute__ is the weird one. I think of implementing __getattr_ Somehow I missed this comment. I implemented your __getattr__, but not the args overwrite. So half-done in the latest patch set. -- To view, visit http://gerrit.cloudera.org:8080/9770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb Gerrit-Change-Number: 9770 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 28 Mar 2018 18:34:23 +0000 Gerrit-HasComments: Yes
