Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 )
Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata ...................................................................... Patch Set 4: (4 comments) Thanks for the review. About INVALIDATE METADATA: its TStmtType is DDL, however its TCatalogOpType is RESET_METADATA. And it also doesn't return a TDdlExecResponse, but a TResetMetadataResponse, which doesn't have a TResultSet. So, this commit won't affect INVALIDATE/RESET METADATA. http://gerrit.cloudera.org:8080/#/c/9090/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9090/4//COMMIT_MSG@14 PS4, Line 14: CalatopOpExecutor > typo Done http://gerrit.cloudera.org:8080/#/c/9090/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/9090/4/fe/src/main/java/org/apache/impala/service/Frontend.java@503 PS4, Line 503: if (ddl.op_type == TCatalogOpType.DDL) { > This might need a one-line comment, e.g. "All DDL commands return a string Done http://gerrit.cloudera.org:8080/#/c/9090/4/fe/src/main/java/org/apache/impala/service/Frontend.java@504 PS4, Line 504: metadata.setColumns(Arrays.asList(new TColumn("summary", Type.STRING.toThrift()))); > Can we add a corresponding assert (probably in impala-server.cc) that all ( I added a DCHECK in ClientRequestState::Wait(). The e2e tests already checked that, however. If an operation declared a result set schema, then the test started to fetch the results, and if there was no result set, the test failed with an error. http://gerrit.cloudera.org:8080/#/c/9090/4/testdata/workloads/functional-query/queries/QueryTest/alter-table.test File testdata/workloads/functional-query/queries/QueryTest/alter-table.test: http://gerrit.cloudera.org:8080/#/c/9090/4/testdata/workloads/functional-query/queries/QueryTest/alter-table.test@234 PS4, Line 234: jointbl_test > it's a bit inconsistent that we include the table name in this message but Yeah, I agree. Done. -- To view, visit http://gerrit.cloudera.org:8080/9090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic542fb8e49e850052416ac663ee329ee3974e3b9 Gerrit-Change-Number: 9090 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Mar 2018 22:48:27 +0000 Gerrit-HasComments: Yes
