Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 )
Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9090/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/9090/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@506 PS5, Line 506: addSummary(response, "New location has been set."); > I think we need to tweak this case to behave more like SET_ROW_FORMAT and o Looking at the definition of alterTableSetLocation() it seems to me that if a partition spec is provided, then only one partition will be affected. Or, there can be subpartitions I guess, but I'm not sure how to count them. Anyway, I added an if-else with different summaries. -- To view, visit http://gerrit.cloudera.org:8080/9090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic542fb8e49e850052416ac663ee329ee3974e3b9 Gerrit-Change-Number: 9090 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 15:36:52 +0000 Gerrit-HasComments: Yes
