Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/9857 )
Change subject: IMPALA-6389: Make '\0' delimited text files work
......................................................................
Patch Set 1:
Here's the diff highlighting the issue:
diff --git a/be/src/exec/delimited-text-parser-test.cc
b/be/src/exec/delimited-text-parser-test.cc
index d8e977d..7df9f06 100644
--- a/be/src/exec/delimited-text-parser-test.cc
+++ b/be/src/exec/delimited-text-parser-test.cc
@@ -150,16 +150,17 @@ TEST(DelimitedTextParser, SpecialDelimiters) {
const char TUPLE_DELIM = '\n'; // implies '\r' and "\r\n" are also delimiters
const char NUL_DELIM = '\0';
const int NUM_COLS = 1;
+ const int MAX_COLS = 2;
- bool is_materialized_col[NUM_COLS];
- for (int i = 0; i < NUM_COLS; ++i) is_materialized_col[i] = true;
+ bool is_materialized_col[MAX_COLS];
+ for (int i = 0; i < MAX_COLS; ++i) is_materialized_col[i] = true;
TupleDelimitedTextParser tuple_delim_parser(NUM_COLS, 0, is_materialized_col,
TUPLE_DELIM);
TupleDelimitedTextParser nul_delim_parser(NUM_COLS, 0, is_materialized_col,
NUL_DELIM);
- TupleDelimitedTextParser nul_field_parser(2, 0, is_materialized_col,
+ TupleDelimitedTextParser nul_field_parser(MAX_COLS, 0, is_materialized_col,
TUPLE_DELIM, NUL_DELIM);
// Non-SSE case
--
To view, visit http://gerrit.cloudera.org:8080/9857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2190c57681f29f34ee1eb393e30dfdda5839098c
Gerrit-Change-Number: 9857
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <[email protected]>
Gerrit-Reviewer: Zach Amsden <[email protected]>
Gerrit-Comment-Date: Thu, 29 Mar 2018 21:35:19 +0000
Gerrit-HasComments: No
