Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9857 )
Change subject: IMPALA-6389: Make '\0' delimited text files work ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9857/1/be/src/exec/delimited-text-parser-test.cc File be/src/exec/delimited-text-parser-test.cc: http://gerrit.cloudera.org:8080/#/c/9857/1/be/src/exec/delimited-text-parser-test.cc@161 PS1, Line 161: nul_delim_parser would it make sense to call this nul_column_parser (analogous to nul_field_parser) since delim doesn't really tell is which delimiter is nul? -- To view, visit http://gerrit.cloudera.org:8080/9857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2190c57681f29f34ee1eb393e30dfdda5839098c Gerrit-Change-Number: 9857 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 29 Mar 2018 22:48:09 +0000 Gerrit-HasComments: Yes
