Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 )
Change subject: IMPALA-6739: Exception in ALTER TABLE SET statements ...................................................................... Patch Set 10: (2 comments) Since these particular statements never passed query compilation in the past, it would be good to have end-to-end tests to make sure they actually run with an empty partition set. You can add tests in the .test files run from "test_partition_ddl_predicates" in "test_ddl.py" http://gerrit.cloudera.org:8080/#/c/9819/10/fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java: http://gerrit.cloudera.org:8080/#/c/9819/10/fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java@84 PS10, Line 84: if (partitions.isEmpty()) { single line http://gerrit.cloudera.org:8080/#/c/9819/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/9819/10/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@547 PS10, Line 547: AnalyzesOk("alter table functional.alltypesagg partition(year=2009, month=1) " + IF EXISTS is not relevant here because this particular ALTER does not have the IF EXISTS clause right? -- To view, visit http://gerrit.cloudera.org:8080/9819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I793e827d5cf5b7986bd150dd9706df58da3417f3 Gerrit-Change-Number: 9819 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 01:18:47 +0000 Gerrit-HasComments: Yes
