Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9884 )

Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for 
HBase tables
......................................................................


Patch Set 2:

> Patch Set 1:
>
> I was curious to see if we'd see this anywhere else, and I ran the following 
> against the minicluster. It looked to me that the only other category where 
> "show create table" didn't work has reasonable "this is not supported" 
> messages.
>
> $(for db in $(impala-shell.sh -B --query 'show databases' 2> /dev/null | awk 
> '{ print $1 }'); do for table in $(impala-shell.sh -B --query "show tables in 
> $db" 2> /dev/null); do impala-shell.sh -B --query "show create table 
> $db.$table"; done; done) |& tee /tmp/out

Thanks for the awesome script. I ran your script with my patch and most tables 
were able to run "show create table" with the exception of those tables that 
are not supported, i.e INDEX_TABLE, etc.: 
https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/TableLoader.java#L36-L37


--
To view, visit http://gerrit.cloudera.org:8080/9884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Comment-Date: Mon, 02 Apr 2018 18:50:45 +0000
Gerrit-HasComments: No

Reply via email to