Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9884 )
Change subject: IMPALA-6571: NullPointerException in SHOW CREATE TABLE for HBase tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/9884/2/tests/metadata/test_show_create_table.py@37 PS2, Line 37: last_modified_by", : "last_modified_time"] > Quick question, why are these added now? Don't see them in the show create They are in some tables. [localhost:21000] > show create table functional_hbase.alltypes; Query: show create table functional_hbase.alltypes +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | result | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | CREATE EXTERNAL TABLE functional_hbase.alltypes ( | | id INT COMMENT 'Add a comment', | | bigint_col BIGINT, | | bool_col BOOLEAN, | | date_string_col STRING, | | double_col DOUBLE, | | float_col FLOAT, | | int_col INT, | | month INT, | | smallint_col SMALLINT, | | string_col STRING, | | timestamp_col TIMESTAMP, | | tinyint_col TINYINT, | | year INT | | ) | | STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' | | WITH SERDEPROPERTIES ('hbase.columns.mapping'=':key,d:bool_col,d:tinyint_col,d:smallint_col,d:int_col,d:bigint_col,d:float_col,d:double_col,d:date_string_col,d:string_col,d:timestamp_col,d:year,d:month', 'serialization.format'='1') | | TBLPROPERTIES ('hbase.table.name'='functional_hbase.alltypes', 'last_modified_by'='fwijaya', 'last_modified_time'='1522345971', 'storage_handler'='org.apache.hadoop.hive.hbase.HBaseStorageHandler') | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ last_modifed_by and last_modified_time are properties that can change all the time. It's better to ignore those properties. -- To view, visit http://gerrit.cloudera.org:8080/9884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe018313168fac5dcbd80be9a8f28b71a2c0389b Gerrit-Change-Number: 9884 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 02 Apr 2018 19:30:17 +0000 Gerrit-HasComments: Yes
