Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9913 )
Change subject: IMPALA-6785: reset failed heartbeat count when re-registering ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9913/4/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/9913/4/be/src/statestore/statestore.h@520 PS4, Line 520: The : /// subscriber ID is used to identify peers for failure detection purposes. > why is it that using subscriber ID is the right thing, rather than go back I don't think it actually matters so long as its consistent. We need to evict the entry from the cache when the subscriber is unregistered regardless so that we don't get stale state or unbounded growth in the entries, so for the lifetime of the failure detector entry there's a 1:1 relationship between subscriber and registration ID. One advantage of using subscriber ID is that the test I added can detect if we mess this up. If we had a similar bug with registration ID we'd just get the failure detector growing unbounded. -- To view, visit http://gerrit.cloudera.org:8080/9913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07 Gerrit-Change-Number: 9913 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Apr 2018 16:49:02 +0000 Gerrit-HasComments: Yes
