Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9913 )
Change subject: IMPALA-6785: reset failed heartbeat count when re-registering ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9913/4/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/9913/4/be/src/statestore/statestore.h@520 PS4, Line 520: The : /// subscriber ID is used to identify peers for failure detection purposes. > Right, but in either case we want to start with a clean failure detection s Doesn't that argue that we should use the registeration id? Using the subscriber id means that the failure detector will consider the history from the previous instance of this subscriber since the same key is used, no? -- To view, visit http://gerrit.cloudera.org:8080/9913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ad409e2a8e22d081fce97b085b9469ab046bf07 Gerrit-Change-Number: 9913 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Apr 2018 17:10:33 +0000 Gerrit-HasComments: Yes
