Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 )
Change subject: IMPALA-5717: Support for reading ORC data files ...................................................................... Patch Set 12: (4 comments) Had some minor comments, but I'm ready to +2 this otherwise. I want to do some additional testing myself to make sure that it passes some common build types - S3, AddressSanitizer, etc, but I can do that in parallel with the last revisions. http://gerrit.cloudera.org:8080/#/c/9134/12/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/9134/12/be/src/exec/hdfs-orc-scanner.cc@24 PS12, Line 24: #include "runtime/collection-value-builder.h" Some includes not needed: collection-value-builder.h scoped-buffer.h bitmap.h dict-encoding.h http://gerrit.cloudera.org:8080/#/c/9134/12/be/src/exec/hdfs-orc-scanner.cc@350 PS12, Line 350: return Status(Substitute("ORC column $0 can't be truncated to table column $1", Should include filename() in the message so users can trace back the error. http://gerrit.cloudera.org:8080/#/c/9134/12/be/src/exec/hdfs-orc-scanner.cc@355 PS12, Line 355: return Status(Substitute("Type mismatch: table column $0 is map to ORC column $1", Should include filename() in the message so users can trace back the error. http://gerrit.cloudera.org:8080/#/c/9134/12/be/src/exec/hdfs-orc-scanner.cc@606 PS12, Line 606: VLOG_FILE I think this should be VLOG_ROW because it logs many times per file. -- To view, visit http://gerrit.cloudera.org:8080/9134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4 Gerrit-Change-Number: 9134 Gerrit-PatchSet: 12 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 06:38:23 +0000 Gerrit-HasComments: Yes
