Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 )
Change subject: IMPALA-5717: Support for reading ORC data files ...................................................................... Patch Set 13: Code-Review+2 I'm still in the process of running tests. I'm a little concerned that the AddressSanitizer test is hung, but I may not have time to investigate before the weekend (I'm taking Friday off). AddressSanitizer is easy enough to run locally - you just pass the -asan option to buildall.sh. S3 is tricky to set up - you need a data snapshot and an S3 bucket. I'm not sure that I'm actually going to be able to run that precommit because it's not trivial to get it set up correctly with new data. -- To view, visit http://gerrit.cloudera.org:8080/9134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4 Gerrit-Change-Number: 9134 Gerrit-PatchSet: 13 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 06 Apr 2018 00:16:29 +0000 Gerrit-HasComments: No
