Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 )
Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py@31 PS1, Line 31: > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py@45 PS1, Line 45: row > should this be encoded in the same way? It's already a str (verified by printing type(rows[0][0])). I added a test for this code path too, since it is different. http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py@64 PS1, Line 64: rows > should this be "rows.encode(...)"? I checked that the returned rows is already a str instead of a unicode, so re-encoding it is not necessary. We already have test coverage for this case. -- To view, visit http://gerrit.cloudera.org:8080/9928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9de641ecf767a2feef3b9f48b344ef2d55e17a7f Gerrit-Change-Number: 9928 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 18:31:09 +0000 Gerrit-HasComments: Yes
