Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9928 )
Change subject: IMPALA-2717: fix output of formatted unicode to non-TTY ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9928/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9928/1/shell/impala_shell.py@73 PS1, Line 73: """Patched version of PrettyTable that TODO""" > Not your change, but would you mind filling in the TODO? The difference see Hah oh dear. http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/9928/1/shell/shell_output.py@45 PS1, Line 45: row > I looked around a bit and tried to figure out how passing a str into add_ro I extended the current comment to explain the two-way conversion. http://gerrit.cloudera.org:8080/#/c/9928/2/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/9928/2/shell/shell_output.py@31 PS2, Line 31: contained > nit: containing? Done http://gerrit.cloudera.org:8080/#/c/9928/2/shell/shell_output.py@58 PS2, Line 58: contained > here too? Done -- To view, visit http://gerrit.cloudera.org:8080/9928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9de641ecf767a2feef3b9f48b344ef2d55e17a7f Gerrit-Change-Number: 9928 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 11 Apr 2018 21:57:20 +0000 Gerrit-HasComments: Yes
