Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 )
Change subject: IMPALA-6805: Show current database in Impala shell prompt ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9927/6/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9927/6/tests/shell/test_shell_interactive.py@520 PS6, Line 520: Can you add some more test cases? This might be too exhaustive in some cases, so feel free to do a little pushback, but I'm thinking as a user here: 1. Using backticks, which you've coded for but not tested. 2. Including whitespace both without and with backticks, e.g., "use ` tpch `;" 3. When using impala-shell -i invalid_host, what is the database printed? Does this make sense from a user's perspective? 4. When the shell becomes disconnected, what is the database printed? Does this make sense from a user's perspective? 5. When issuing "connect" to connect to a different coordinator, what is the database printed? 6. When doing 5 above, if you do this on a coordinator that doesn't have the database known to the first coordinator, what is the database printed? -- To view, visit http://gerrit.cloudera.org:8080/9927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0ae58507321e426e5f0f16518671420974a3fc Gerrit-Change-Number: 9927 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Apr 2018 01:18:06 +0000 Gerrit-HasComments: Yes
