Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9927 )
Change subject: IMPALA-6805: Show current database in Impala shell prompt ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Carry +1 http://gerrit.cloudera.org:8080/#/c/9927/6/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/9927/6/tests/shell/test_shell_interactive.py@520 PS6, Line 520: proc.expect(":21000] functional>") > Can you add some more test cases? This might be too exhaustive in some case - For items 1-2, I added new tests. - For item 3, there's already an existing test for it: https://github.com/apache/impala/blob/master/tests/shell/test_shell_interactive.py#L144. - For item 4, I don't really know how to simulate this unless we kill the coordinator. Although I'm fairly certain the behavior is the same as item 3. - For item 5, I added another assert in the existing test_reconnect() test. - For item 5, I also don't quite know how to test this. -- To view, visit http://gerrit.cloudera.org:8080/9927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0ae58507321e426e5f0f16518671420974a3fc Gerrit-Change-Number: 9927 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Tue, 10 Apr 2018 03:02:57 +0000 Gerrit-HasComments: Yes
