Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9942 )
Change subject: IMPALA-6817: Clean up Impala privilege model ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9942/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java File fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java: http://gerrit.cloudera.org:8080/#/c/9942/8/fe/src/compat-minicluster-profile-3/java/org/apache/impala/authorization/ImpalaActionFactory.java@35 PS8, Line 35: actions.add(new BitFieldAction(action.getValue(), action.getCode())); > Putting static values here, isn't it going to defeat the purpose of having You could have a BitFieldAction member in ImpalaAction instead of the code member. http://gerrit.cloudera.org:8080/#/c/9942/8/fe/src/test/java/org/apache/impala/authorization/ImpalaActionFactoryTest.java File fe/src/test/java/org/apache/impala/authorization/ImpalaActionFactoryTest.java: http://gerrit.cloudera.org:8080/#/c/9942/8/fe/src/test/java/org/apache/impala/authorization/ImpalaActionFactoryTest.java@71 PS8, Line 71: assertBitFieldActions(expected, actual); > When 1 << 10, expected should be empty. I'll add a test. Seems odd to rely on undefined behavior here. Maybe the interface doesn't prescribe a behavior but our concrete implementation should do something sane. -- To view, visit http://gerrit.cloudera.org:8080/9942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65f3f9b4d06f3b03bfa2f484737bb746ec598a6b Gerrit-Change-Number: 9942 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 10 Apr 2018 03:18:44 +0000 Gerrit-HasComments: Yes
