Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9951 )

Change subject: IMPALA-6824: Fix crash in 
RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................

IMPALA-6824: Fix crash in RuntimeProfile::EventSequence::AddNewerEvents()

When events_ is empty in runtime-profile-counters.h:347, events_.back()
is undefined. This can lead to a crash. The fix is to check for
events_.empty() before calling back().

This change adds a backend test to make sure that updating empty event
sequences doesn't crash.

Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Reviewed-on: http://gerrit.cloudera.org:8080/9951
Reviewed-by: Lars Volker <l...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
M be/src/util/runtime-profile-counters.h
M be/src/util/runtime-profile-test.cc
2 files changed, 34 insertions(+), 2 deletions(-)

Approvals:
  Lars Volker: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

Reply via email to