Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9951 )

Change subject: IMPALA-6824: Fix crash in 
RuntimeProfile::EventSequence::AddNewerEvents()
......................................................................


Patch Set 2:

(1 comment)

The build hit IMPALA-6092, will restart it.

http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:

http://gerrit.cloudera.org:8080/#/c/9951/1/be/src/util/runtime-profile-counters.h@348
PS1, Line 348:     for (int64_t i = 0; i < timestamps.size(); ++i) {
> Let's not bother reserving, this code isn't perf critical so it doesn't rea
Done



--
To view, visit http://gerrit.cloudera.org:8080/9951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d30517544e8aa40e7d041f6a65a5dd361ae3c1
Gerrit-Change-Number: 9951
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 10 Apr 2018 00:27:43 +0000
Gerrit-HasComments: Yes

Reply via email to