Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9994 )
Change subject: IMPALA-6809: Allow bootstrap_system.sh in non ~/Impala directory ...................................................................... Patch Set 3: (3 comments) Seems fine. I've got minor suggestions. http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@24 PS3, Line 24: # variables to make Impala compile and run after this script is complete. Add a note here that it respects IMPALA_HOME http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@102 PS3, Line 102: if ! [[ -v IMPALA_HOME ]] Impala house style for this is: : ${IMPALA_HOME:=~/Impala} instead of lines 102-105. http://gerrit.cloudera.org:8080/#/c/9994/3/bin/bootstrap_system.sh@208 PS3, Line 208: if ! [[ -d $IMPALA_HOME/../Impala-lzo ]] Define IMPALA_LZO_HOME next to where you define IMPALA_HOME and use that? -- To view, visit http://gerrit.cloudera.org:8080/9994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3241c180b5fb28f1b5f939200f72461ad6fd7d7a Gerrit-Change-Number: 9994 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Apr 2018 23:22:13 +0000 Gerrit-HasComments: Yes
