Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10032 )
Change subject: IMPALA-5392. Add full stack trace to jvm-threadz ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10032/1/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10032/1/fe/src/main/java/org/apache/impala/common/JniUtil.java@243 PS1, Line 243: private static String createSummary(ThreadInfo threadInfo) { Instead of doing the formatting yourself, did you consider using getThreadInfo() method from ThreadMXBean that can take the max depth as a parameter and then call toString()? You may have to make an extra call to get locks and monitors, but you may want to see if it is simpler that way. Also, can you please post a screenshot of the threadz tab with your changes so that we can see how that thing looks like? -- To view, visit http://gerrit.cloudera.org:8080/10032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibee595358ebc2e1b48cb73356faff7a708aa6a80 Gerrit-Change-Number: 10032 Gerrit-PatchSet: 1 Gerrit-Owner: Charles Agnello <charles.w.agne...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 18:03:08 +0000 Gerrit-HasComments: Yes
