Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 )
Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 ...................................................................... Patch Set 1: We also have the source code for sqlparse checked into the repo for the shell. Should we also upgrade that version? The argument for that is that it will minimise divergence between the shell's behaviour and our test's behaviour. -- To view, visit http://gerrit.cloudera.org:8080/10044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5289f86b78f1d77d91a8fa47d63b7a7eaa3af38 Gerrit-Change-Number: 10044 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Apr 2018 15:48:57 +0000 Gerrit-HasComments: No
