Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0 ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml File docs/topics/impala_upgrading.xml: http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@149 PS1, Line 149: you is "you" the style used throughout the docs for such cases? seems a bit too informal. http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@151 PS1, Line 151: startup option, <codeph>reserved_words_version</codeph>, to : <codeph>"2.11.0"</codeph>. If this is a flag that's passed to the binary, lets call it a flag, along with making it look like a flag, e.g.: "--reserved_words_version=2.11.0" Would that be consistent with other "startup options"? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@157 PS1, Line 157: /></title> single line http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@159 PS1, Line 159: implementation implementations http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@163 PS1, Line 163: you "you"? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@164 PS1, Line 164: your your? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@165 PS1, Line 165: <codeph>DECIMAL_V2</codeph> query option to : <codeph>FALSE</codeph>. just asking, do we typically provide the "set" command for these cases so its easy to cut-and-paste? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@188 PS1, Line 188: > 3;</codeblock> is it worth pointing out the error message? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@211 PS1, Line 211: <p> The default value for the <codeph>PARQUET_ARRAY_RESOLUTION</codeph> the query option? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@213 PS1, Line 213: Parquet standard 3-level : encoding. external link to this? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@219 PS1, Line 219: for the information about the query option.</p> is it obvious what happens here if I don't think much about this change? in other words, should I expect some files to no longer be read, expect additional files to be read, or something else? http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@226 PS1, Line 226: >clustered</keyword> hint is enabled by default. The hint inserts a fix break -- To view, visit http://gerrit.cloudera.org:8080/10080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89 Gerrit-Change-Number: 10080 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 16 Apr 2018 22:11:51 +0000 Gerrit-HasComments: Yes
