Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10080 )

Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@150
PS3, Line 150:           identifier, e.g. a table name, enclose the word in 
quotes.
enclose the word in backticks.

(*not* quotes)


http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@155
PS3, Line 155:           startup flag: 
<codeph>--reserved_words_version=2.11.0</codeph>.
Note that this startup option will eventually be deprecated.


http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@184
PS3, Line 184:           To conform to the SQL standard, Impala no longer 
performs alias
probably better to just link to the documentation and not repeat all examples 
here


http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@190
PS3, Line 190:           For example, the following statements will result in 
syntax errors.
They will not result in syntax errors, but error in semantic analysis (probably 
better to not list the examples here)


http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@234
PS3, Line 234:           The <codeph>PARQUET_ARRAY_RESOLUTION</codeph> query 
option controls
Remove this paragraph and merge the last sentence linking to the query options 
docu page with the paragraph in 230?


http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@247
PS3, Line 247:             >clustered</keyword> hint is enabled by default. The 
hint inserts a
The hint adds a local sort...

(better to not use "insert" since it could be misunderstood)



--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 22:01:33 +0000
Gerrit-HasComments: Yes

Reply via email to