Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml File docs/topics/impala_grant.xml: http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@105 PS1, Line 105: The <codeph>REFRESH</codeph> privilege is required to execute It would be much nicer to have all this information presented in a table with 3 columns (privilege, scope, SQL statements). http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml File docs/topics/impala_revoke.xml: http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@45 PS1, Line 45: specified object from groups. The revocation has a cascading effect. For I don't know where we want to add this info. Currently we are treating ALL as a distinct privilege. ALL is not a union of all other privileges. In other words, revoking SELECT, INSERT, CREATE, ALTER, etc. on ALL is a no-op. http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@58 PS1, Line 58: privilege ::= ALTER | CREATE | SELECT | SELECT(<varname>column_name</varname>) | INSERT | ALL Missing REFRESH privilege. -- To view, visit http://gerrit.cloudera.org:8080/10079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab Gerrit-Change-Number: 10079 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Apr 2018 16:14:38 +0000 Gerrit-HasComments: Yes
