Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 )
Change subject: IMPALA-6651: [DOCS] Fine grained privileges ...................................................................... Patch Set 2: (18 comments) http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml File docs/topics/impala_grant.xml: http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@44 PS1, Line 44: statement grants a privilege on a specified object : to a role or grant > Should we change the wording of this? We can grant privileges to a role, a Done http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@105 PS1, Line 105: <stentry>Scope</stentry> > It would be much nicer to have all this information presented in a table wi Done http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_grant.xml@118 PS1, Line 118: <stentry><codeph>REFRESH</codeph></stentry> : <stentry><codeph>DATABASE</codeph></stentry> : <stentry><codeph>INVALIDATE METADAT > This is slightly different than create. DROP at the server level allows yo Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml File docs/topics/impala_grant.xml: http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@130 PS2, Line 130: <varname>the named table</varname><p><codeph>REFRESH</codeph> > "on the named table" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@131 PS2, Line 131: <varname>the named table</varname></p></stentry> > "on the named table" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@137 PS2, Line 137: <varname>all databases</varname><p><codeph>CREATE TABLE</codeph> > "on all databases" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@138 PS2, Line 138: <varname>all tables</varname></p></stentry> > "on all tables" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@144 PS2, Line 144: <varname>all tables in the named database</varname></stentry> > "on all tables in the named database" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@150 PS2, Line 150: <varname>all databases</varname><p><codeph>DROP TABLE</codeph> > "on all databases" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@151 PS2, Line 151: <varname>all tables</varname></p></stentry> > "on all tables" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@157 PS2, Line 157: <varname>the named database</varname><p><codeph>DROP TABLE</codeph> > "on the named database" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@158 PS2, Line 158: <varname>all tables in the named database</varname></p></stentry> > "on all tables in the named database" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@164 PS2, Line 164: <varname>the named table</varname></stentry> > "on the named table" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@170 PS2, Line 170: <varname>all tables</varname></stentry> > "on all tables" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@176 PS2, Line 176: <varname>tables in the named database</varname></stentry> > "on all tables in the named database" Done http://gerrit.cloudera.org:8080/#/c/10079/2/docs/topics/impala_grant.xml@182 PS2, Line 182: <varname>the named table</varname></stentry> > "on the named table" Done http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml File docs/topics/impala_revoke.xml: http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@45 PS1, Line 45: cascading effect. For example, revoking the <codeph>ALL</codeph> privilege > I don't know where we want to add this info. Currently we are treating ALL Done http://gerrit.cloudera.org:8080/#/c/10079/1/docs/topics/impala_revoke.xml@58 PS1, Line 58: privilege ::= ALL | ALTER | CREATE | DROP | INSERT | REFRESH | SELECT | SELECT(<varname>column_name</varname>) > Missing REFRESH privilege. Done -- To view, visit http://gerrit.cloudera.org:8080/10079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b018bf847537ed461df6d9caee99f90b139f8ab Gerrit-Change-Number: 10079 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 18 Apr 2018 16:17:12 +0000 Gerrit-HasComments: Yes
