Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10108 )
Change subject: IMPALA-6878: SentryServicePinger should not print stacktrace at every retry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java File fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java: http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java@45 PS1, Line 45: logger4j.setLevel(Level.OFF); Are we sure we want this off? Versus setting it to a lower log level. Also just making sure that we won't lose out on any information that we had earlier, due to this? -- To view, visit http://gerrit.cloudera.org:8080/10108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26f9a141c89692443cb3cdcb6bf62581a93b5ba0 Gerrit-Change-Number: 10108 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Apr 2018 23:21:54 +0000 Gerrit-HasComments: Yes
