Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10108 )
Change subject: IMPALA-6878: SentryServicePinger should not print stacktrace at every retry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java File fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java: http://gerrit.cloudera.org:8080/#/c/10108/1/fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java@45 PS1, Line 45: logger4j.setLevel(Level.OFF); > Are we sure we want this off? That's for something that's logged in Sentry and not in this class. We still capture the Sentry exception in L87 and print it at the end at L95. This is also to prevent duplicate Sentry exception messages. In successful case: SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/fwijaya/Impala/fe/target/dependency/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/fwijaya/Impala/testdata/target/dependency/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] 18/04/18 16:03:36 INFO testutil.SentryServicePinger: Sentry Service ping succeeded. In failure case: 18/04/18 16:25:48 ERROR testutil.SentryServicePinger: Error issuing RPC to Sentry Service (attempt 1/1) 18/04/18 16:25:50 ERROR testutil.SentryServicePinger: Error starting Sentry Service: org.apache.impala.common.InternalException: Error making 'listRoles' RPC to Sentry Service: at org.apache.impala.util.SentryPolicyService.listAllRoles(SentryPolicyService.java:405) at org.apache.impala.testutil.SentryServicePinger.main(SentryServicePinger.java:83) Caused by: sentry.org.apache.sentry.core.common.exception.SentryUserException: java.net.ConnectException: Connection refused (Connection refused) at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.connect(RetryClientInvocationHandler.java:166) at sentry.org.apache.sentry.core.common.transport.RetryClientInvocationHandler.invokeImpl(RetryClientInvocationHandler.java:90) at sentry.org.apache.sentry.core.common.transport.SentryClientInvocationHandler.invoke(SentryClientInvocationHandler.java:41) at com.sun.proxy.$Proxy5.listAllRoles(Unknown Source) at org.apache.impala.util.SentryUtil.listRoles(SentryUtil.java:52) at org.apache.impala.util.SentryPolicyService.listAllRoles(SentryPolicyService.java:398) ... 1 more -- To view, visit http://gerrit.cloudera.org:8080/10108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26f9a141c89692443cb3cdcb6bf62581a93b5ba0 Gerrit-Change-Number: 10108 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Apr 2018 23:29:56 +0000 Gerrit-HasComments: Yes
