Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: [Preview]IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 2: (2 comments) missed a small change regarding update of query state in the impala-beeswax-server, will do in the next patch http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/runtime/coordinator.h@328 PS2, Line 328: /// True if and only if Exec() has been called and returned with an OK status. : bool execution_started_ = false; forgot to remove this. will do in the next patch http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/runtime/coordinator.cc@160 PS2, Line 160: // Ensure 'this' Coordinator object can be safely destroyed. : DCHECK(query_status_.ok()); : query_status_ = prepare_status; : CancelInternal(); > this is somewhat subtle logic, so it'd be good to combine it with the tail makes sense, will do in the next patch -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Apr 2018 22:48:58 +0000 Gerrit-HasComments: Yes
