Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 )
Change subject: IMPALA-2195: Improper handling of comments in queries ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1279 PS3, Line 1279: self._replace_history_delimiters('\n', ImpalaShell.HISTORY_FILE_QUERY_DELIM) > Sorry for the late reply. I was busy with some other tasks. Your concern is Ya, I see your point. As discussed offline, I think we can totally remove the dependency on cmd's parseline() here to workaround this. We already do that for '@' implementation, similarly, we can just copy the rest of it (from cmd.py) and control how 'line' changes and work on a comment stripped query to deduce the 'cmd' part. -- To view, visit http://gerrit.cloudera.org:8080/9933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7 Gerrit-Change-Number: 9933 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 05:21:41 +0000 Gerrit-HasComments: Yes
