Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 )
Change subject: IMPALA-2195: Improper handling of comments in queries ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9933/3/shell/impala_shell.py@1279 PS3, Line 1279: self._replace_history_delimiters('\n', ImpalaShell.HISTORY_FILE_QUERY_DELIM) > Right. Currently, if you see the web UI of the running/completed queries, i Sorry for the late reply. I was busy with some other tasks. Your concern is totally valid. I have an updated PR that is hopefully fixes the bug as well as addressing your concern. Upon further investigation, apparently any non front-end commands, e.g. SUMMARY, HELP, etc. that start with a leading comment will result in a syntax error because it calls the default() method which sends the command to the front-end and front-end has no knowledge about those commands. -- To view, visit http://gerrit.cloudera.org:8080/9933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7cb5a30e6dda73ebe761d9f0eb9ba038e14a7 Gerrit-Change-Number: 9933 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Wed, 18 Apr 2018 05:51:56 +0000 Gerrit-HasComments: Yes
