Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10123 )
Change subject: IMPALA-6070: Further improvements to test-with-docker. ...................................................................... Patch Set 1: (5 comments) Made it through a first pass, and everything looks good to me so far. http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh@124 PS1, Line 124: isue Nit: issue http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh@187 PS1, Line 187: -skiptests Nit: -notests implies -skiptests http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh@288 PS1, Line 288: capt cap http://gerrit.cloudera.org:8080/#/c/10123/1/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/10123/1/tests/conftest.py@514 PS1, Line 514: hasing hashing http://gerrit.cloudera.org:8080/#/c/10123/1/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/10123/1/tests/run-tests.py@239 PS1, Line 239: Nit: stray line -- To view, visit http://gerrit.cloudera.org:8080/10123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c Gerrit-Change-Number: 10123 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 18:32:37 +0000 Gerrit-HasComments: Yes
