Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/10123 )
Change subject: IMPALA-6070: Further improvements to test-with-docker. ...................................................................... Patch Set 1: (3 comments) Just a couple of typos and an 'env' filtering request. Looks good; I wonder if an m5 or c5 instance can make it run in 2 hours... http://gerrit.cloudera.org:8080/#/c/10123/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10123/1//COMMIT_MSG@26 PS1, Line 26: it more in Python, with a class representing a suite with a Nit: possible typo (it -> bit) http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/10123/1/docker/entrypoint.sh@379 PS1, Line 379: env I know this is not likely to run against S3 anytime soon, but would you mind adding the grep clause to filter out the AWS_ secrets, so that it doesn't bite us later? e.g. env | grep -vE "AWS_(SECRET_)?ACCESS_KEY" http://gerrit.cloudera.org:8080/#/c/10123/1/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/10123/1/docker/test-with-docker.py@283 PS1, Line 283: ne nit: typo: environmental -- To view, visit http://gerrit.cloudera.org:8080/10123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43fe124f00340afa21ad1eeb6432d6d50151ca7c Gerrit-Change-Number: 10123 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 13:28:04 +0000 Gerrit-HasComments: Yes
