Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10156 )
Change subject: IMPALA-6889: Fix race around terminating processes ...................................................................... Patch Set 1: (1 comment) Thanks again for looking! http://gerrit.cloudera.org:8080/#/c/10156/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/10156/1/tests/common/impala_cluster.py@116 PS1, Line 116: cmdline = process.cmdline Will this actually fix the race, or narrow the race? It seems like the race between L104 and L116 still exists. I agree that from L116 onward is an improvement, so I don't want to block this, just asking the question at this time. -- To view, visit http://gerrit.cloudera.org:8080/10156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf630e0b71d91469650636e81f940a7bec07113 Gerrit-Change-Number: 10156 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 19:02:43 +0000 Gerrit-HasComments: Yes
