Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/10156 )
Change subject: IMPALA-6889: Fix race around terminating processes
......................................................................
IMPALA-6889: Fix race around terminating processes
A process with empty cmdline can trip up the Process class in our test
code. When a process dies it becomes a zombie until it gets reaped by
its parent.
>From 'man proc':
/proc/[pid]/cmdline
This read-only file holds the complete command line for the
process, unless the process is a zombie. In the latter case,
there is nothing in this file: that is, a read on this file
will return 0 characters. The command-line arguments appear
in this file as a set of strings separated by null bytes
('\0'), with a further null byte after the last string.
To fix this, we take a copy of the cmdline before passing it to the
Process ctor to prevent it from changing.
I couldn't come up with a test for this.
Change-Id: Iecf630e0b71d91469650636e81f940a7bec07113
Reviewed-on: http://gerrit.cloudera.org:8080/10156
Reviewed-by: Michael Brown <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M tests/common/impala_cluster.py
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecf630e0b71d91469650636e81f940a7bec07113
Gerrit-Change-Number: 10156
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
