Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 )
Change subject: IMPALA-5614 (part 1): Implement COMMENT ON DATABASE ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10171/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10171/2//COMMIT_MSG@12 PS2, Line 12: COMMENT ON DATABASE db IS 'comment' We might want to go with ALTER DATABASE SET COMMENT for consistency with our existing ALTER TABLE SET COMMENT. Changing a column comment today is also possible through a flavor of ALTER TABLE. Otoh, we might consider adding the COMMENT ON syntax in general. My inclination is to go with ALTER DATABASE SET COMMENT to avoid the additional code/complexity from COMMENT ON since I don't think any user is burning for the COMMENT ON syntax specifically. Let's ask Greg for his input since he originally suggested the COMMENT ON syntax. -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 04:48:05 +0000 Gerrit-HasComments: Yes
