Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10171 )
Change subject: IMPALA-6916: Implement COMMENT ON DATABASE ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/10171/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10171/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1081 PS2, Line 1081: getMetaStoreDb() see comment below, might not be needed. http://gerrit.cloudera.org:8080/#/c/10171/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1578 PS2, Line 1578: getMetaStoreDb() see comment below, might not be needed. http://gerrit.cloudera.org:8080/#/c/10171/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2853 PS2, Line 2853: private void applyAlterDatabase(org.apache.hadoop.hive.metastore.api.Database msDb) See comment below, might not be needed. http://gerrit.cloudera.org:8080/#/c/10171/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3528 PS2, Line 3528: msDb This could just be "db" to avoid the changes to the methods above. -- To view, visit http://gerrit.cloudera.org:8080/10171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf909c18f97073346f6f603538bf921e69fbb00 Gerrit-Change-Number: 10171 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 03:53:05 +0000 Gerrit-HasComments: Yes
