Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20756 )

Change subject: IMPALA-12601: Add a fully partitioned TPC-DS database
......................................................................


Patch Set 1:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py
File bin/load-data.py:

http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@162
PS1, Line 162: def exec_hbase_query_from_file(file_name, step_name):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@270
PS1, Line 270: def exec_query_files_parallel(thread_pool, query_files, 
execution_type, step_name):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@290
PS1, Line 290: def impala_exec_query_files_parallel(thread_pool, query_files, 
step_name):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@293
PS1, Line 293: def hive_exec_query_files_parallel(thread_pool, query_files, 
step_name):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@464
PS1, Line 464: x
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20756/1/bin/load-data.py@474
PS1, Line 474: "
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20756/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/20756/1/testdata/bin/generate-schema-statements.py@257
PS1, Line 257: F
flake8: F405 'FILE_FORMAT_TO_STORED_AS_MAP' may be undefined, or defined from 
star imports: tests.common.test_dimensions, tests.util.test_file_parser


http://gerrit.cloudera.org:8080/#/c/20756/1/testdata/bin/generate-schema-statements.py@257
PS1, Line 257: t
flake8: E501 line too long (93 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/20756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2e66c405639554f325ae78c66628d464f6c453
Gerrit-Change-Number: 20756
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 05 Dec 2023 20:17:13 +0000
Gerrit-HasComments: Yes

Reply via email to