Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20756 )

Change subject: IMPALA-12601: Add a fully partitioned TPC-DS database
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20756/2/testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql
File testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/20756/2/testdata/datasets/tpcds_partitioned/tpcds_partitioned_schema_template.sql@715
PS2, Line 715: foreign key (ss_store_sk) references {db_name}{db_suffix}.store 
(s_store_sk) DISABLE NOVALIDATE RELY
             : foreign key (ss_promo_sk) references 
{db_name}{db_suffix}.promotion (p_promo_sk) DISABLE NOVALIDATE RELY
             : ---- PARTITION_COLUMNS
> Correct. We don't need multi-statement load here because, at small scale pa
I just remember, during "Hive Load Text" step, there will be multiple 
store_sales loading for different text codecs running in parallel. So 
multi-statement load for Hive should stay to keep memory usage low per Hive 
query.

For Impala, maybe multi-statement load can be collapsed to one since it runs by 
itself at "Impala Load". That is if we want to focus the script usage just for 
small scale loading.



--
To view, visit http://gerrit.cloudera.org:8080/20756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2e66c405639554f325ae78c66628d464f6c453
Gerrit-Change-Number: 20756
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 06 Dec 2023 18:50:32 +0000
Gerrit-HasComments: Yes

Reply via email to