[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Alter partition event from hive is treated as self event ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20486/10/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20486/10/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@a2049 PS10, Line 2049: > So we are reverting some changes of 7f7a631. Does it mean 'createEventId' c Yes. self event detection is common for both transactional and non-transactional tables. We use version number for add PartitionEvent self event detection and eventId for InsertEvent self event detection. I have verified AddPartitionEvent, AlterPartitionEvent, InsertEvent, BatchPartitionEvent(with AlterPartitionEvent and InsertEvent) and DropPartitionEvent events. Have tested add/drop with multiple partitions as well. http://gerrit.cloudera.org:8080/#/c/20486/10/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java: http://gerrit.cloudera.org:8080/#/c/20486/10/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@165 PS10, Line 165: catalog_.setMetastoreEventProcessor(eventsProcessor_); > Could you explain why do we need this for this patch? Events generated from previous tests are not processed with eventsProcessor_. So they are being processed in the subsequent tests when eventsProcessor_.processEvents() is called. CatalogServiceCatalog#isEventProcessingActive() fails during CatalogServiceCatalog#evaluateSelfEvent() because catalog_.getMetastoreEventProcessor() is not the instance of MetastoreEventsProcessor. It is a NoOpEventProcessor instance. So doing this similar to MetastoreEventsProcessorTest, to ensure the tests don't process previous testcase events. This is observed with isSelfEvent() during AddPartitionEvent.process() -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 14:27:45 +0000 Gerrit-HasComments: Yes
