[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Alter partition event from hive is treated as self event ...................................................................... Patch Set 10: (2 comments) reworked http://gerrit.cloudera.org:8080/#/c/20486/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20486/8//COMMIT_MSG@10 PS8, Line 10: IMPALA-10502 (co > Could you mention the commit id? There are several commits in IMPALA-10502. It was done with commit id: 7f7a631. Have added this id in the commit message now. http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4538 PS8, Line 4538: return partsToBeAdded; > Is it true that for non-transactional ADD_PARTITION self-events, this is th "Is it true that for non-transactional ADD_PARTITION self-events, this is the only place to remove items in the inflight event list? and after IMPALA-10502, we don't have a place to do so which cause the next event on the partition being always treated as self-event?" -> Yes. "The method name doesn't indicate it has side effect (modify the partitions). It'd be better to do this in other place or modify the method name." -> Agreed. Have made the change at common place for both transactional and non-transactional cases. -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 03:19:04 +0000 Gerrit-HasComments: Yes
