Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/20506/12/tests/metadata/test_column_unicode.py File tests/metadata/test_column_unicode.py: http://gerrit.cloudera.org:8080/#/c/20506/12/tests/metadata/test_column_unicode.py@35 PS12, Line 35: cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension()) This test still runs "for different file formats" which is completely redundant because the test file already contains different file formats, so the exact same test will run multiple times. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 07 Dec 2023 13:46:12 +0000 Gerrit-HasComments: Yes
