Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Unicode column name support ...................................................................... Patch Set 13: (2 comments) > Patch Set 13: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9985/ To reproduce the compilation error, you need to execute "export USE_APACHE_HIVE=true" before using buildall.sh. http://gerrit.cloudera.org:8080/#/c/20506/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@955 PS13, Line 955: MetaStoreServerUtils This class doesn't exist in apache-hive-3.1.3. I think we should still use MetaStoreUtils#validateColumnName(). https://github.com/apache/hive/blob/rel/release-3.1.3/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java#L505-L507 If the implementation of this method in two MetastoreShim classes are the same, we can put this method in Hive3MetastoreShimBase. http://gerrit.cloudera.org:8080/#/c/20506/13/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/13/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@125 PS13, Line 125: import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils; nit: already imported at L87 -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 07:36:58 +0000 Gerrit-HasComments: Yes
