Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 )
Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1556 PS3, Line 1556: wasEventSyncTurnedOn > Wouldn't it be better to move this block earlier, before self event check? In the above scenario, first (2) is executed, and while reloading table metadata it'll fetch altered table property from HMS. At (3), if the table is loaded, it'll mark the table as stale (See L#809). When (4) arrives, inflight versions will not have (2) since the table was marked as stale in the previous step, so the event is processed and marked that event sync is enabled. If there is no external event before (4), then the event would have been skipped as self-event. I have added an end-to-end test to mimic this scenario. http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1557 PS3, Line 1557: handleEventSyncTurnedOn(); > I think that moving this block to a separate function like handleEventSyncT Ack http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1562 PS3, Line 1562: oad. > Are we prepared for throwing an exception here? Using getTableNoThrow seems Good point. will implement your suggestion -- To view, visit http://gerrit.cloudera.org:8080/20648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37055990be49e91462ebc98aa97009ca768a0072 Gerrit-Change-Number: 20648 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 02:22:20 +0000 Gerrit-HasComments: Yes
