Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 )
Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20648/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20648/1//COMMIT_MSG@22 PS1, Line 22: te l > jumping back to this topic: Completely agree with your argument. Makes sense to me. I'll ignore the event instead of invalidating the metadata object. Should we throw a LOG.warn() saying the next access to this metadata object might be stale so issue IM/RT to fetch the latest snapshot or should I leave it as it is since a lot of events on the disabled table might flood the log with trivial warning? http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20648/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1556 PS3, Line 1556: wasEventSyncTurnedOn > ah, I see, we will see 1 anyway as: Yeah, that's correct. http://gerrit.cloudera.org:8080/#/c/20648/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20648/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@808 PS4, Line 808: instanceof HdfsTable > What should happen with HBase/Kudu tables? We just want to ignore incomplet We can ignore the event if the table is incomplete. But I'm planning to remove this part based on your other comment. -- To view, visit http://gerrit.cloudera.org:8080/20648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37055990be49e91462ebc98aa97009ca768a0072 Gerrit-Change-Number: 20648 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 22:42:18 +0000 Gerrit-HasComments: Yes
