Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 )
Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20754/6/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/20754/6/bin/start-impala-cluster.py@293 PS6, Line 293: result += ["-log_rotation_match_pid=1"] Is '=1' equivalent to '=true'? Seems like an odd way to declare it. http://gerrit.cloudera.org:8080/#/c/20754/6/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20754/6/tests/common/custom_cluster_test_suite.py@311 PS6, Line 311: cmd.append('--ignore_pid_on_log_rotation') This seems like excessive plumbing when you could just pass "impalad_args=-log_rotation_match_pid". -- To view, visit http://gerrit.cloudera.org:8080/20754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I599799e73f27f941a1d7f3dec0f40b4f05ea5ceb Gerrit-Change-Number: 20754 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 22:12:08 +0000 Gerrit-HasComments: Yes
