Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 )
Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20754/5/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/20754/5/bin/start-impala-cluster.py@292 PS5, Line 292: we want > nit: use += [...] to keep consistent with line 295 Done http://gerrit.cloudera.org:8080/#/c/20754/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20754/5/tests/common/custom_cluster_test_suite.py@310 PS5, Line 310: Most of test in custom_cluster need to match PID, exc > nit: most of test in custom_cluster need to match PID, except some test for Done -- To view, visit http://gerrit.cloudera.org:8080/20754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I599799e73f27f941a1d7f3dec0f40b4f05ea5ceb Gerrit-Change-Number: 20754 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2023 19:00:39 +0000 Gerrit-HasComments: Yes
