Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 )
Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20648/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20648/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1563 PS5, Line 1563: if (catalogOpExecutor_.addTableIfNotRemovedLater(getEventId(), msTbl_)) { > Ah, I see. Just realized we will always apply ADD_DATABASE event even if th Ack http://gerrit.cloudera.org:8080/#/c/20648/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20648/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1540 PS6, Line 1540: , > nit: add a comma "," Ack http://gerrit.cloudera.org:8080/#/c/20648/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1583 PS6, Line 1583: ll be skipped a > nit: can we remove "does not exist"? It's misleading. I think we should men Ack -- To view, visit http://gerrit.cloudera.org:8080/20648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37055990be49e91462ebc98aa97009ca768a0072 Gerrit-Change-Number: 20648 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 01:41:05 +0000 Gerrit-HasComments: Yes
